Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass wait_for_done parameter down to _DataflowJobsController #15541

Merged
merged 1 commit into from May 26, 2021

Conversation

dejii
Copy link
Contributor

@dejii dejii commented Apr 26, 2021

When using either DataflowStartFlexTemplateOperator, DataflowTemplatedJobStartOperator or DataflowStartSqlJobOperator. The parameter wait_until_finished seems to have no effect which meant the default behavior is observed regardless of what is passed. First experienced this while using DataflowStartFlexTemplateOperator to trigger a job in streaming mode and the operator returned success when the job's state changed to running despite passing wait_until_finished: True.

        If True, wait for the end of pipeline execution before exiting.
        If False, only submits job.
        If None, default behavior.
        The default behavior depends on the type of pipeline:

        * for the streaming pipeline, wait for jobs to start,
        * for the batch pipeline, wait for the jobs to complete.

This commit fixes that and passes wait_until_finished to the _DataflowJobsController wherever jobs_controller.wait_for_done() is called.

also noticed here: #13262 (comment)


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@dejii dejii requested a review from turbaszek as a code owner April 26, 2021 22:30
@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Apr 26, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 26, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@dejii dejii force-pushed the dataflow-wait-for-done-fix branch from 70e3c59 to f610519 Compare April 26, 2021 22:39
@potiuk potiuk merged commit 6ae9aee into apache:master May 26, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented May 26, 2021

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants