Fix argument ordering and type of bucket and object #15738
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the argument ordering of bucket_name and object_name in GCSHook.download.
All other methods defined on GCSHook have bucket_name before object_name except download.
GoogleCloudStorageHook.download in Airflow 1.0 also defined bucket_name first instead of object_name.
Using object_name, bucket_name causes an issue in BigQueryCreateExternalTableOperator and mlengine_operator_utils.create_evaluate_ops where the parameters to GCSHook.download in those operators are passed positionally.
Additionally, bucket_name is not an optional parameter in the underlying API and is not represented as such in other methods of GCSHook.
Found this while debugging a workflow using BigQueryCreateExternalTableOperator with @FedericaLionetto and stumbling on this log line:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.