Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save pod name to xcom for KubernetesPodOperator #15755

Merged
merged 2 commits into from May 14, 2021

Conversation

junnplus
Copy link
Contributor

closes: #15742


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues area:providers labels May 10, 2021
@mik-laj
Copy link
Member

mik-laj commented May 10, 2021

Can you also save the namespace in xcom also? We can read this value from the constructor parameter, but it's a bit complex and may change after an update DAG. The namespace and pod name will uniquely/easy identify the pod, so from the audit perspective or when we want to add links it will be helpful.

@mik-laj
Copy link
Member

mik-laj commented May 10, 2021

Tests faield. Can you look at it?

@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.

@mik-laj mik-laj merged commit 37d549b into apache:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save pod name in xcom for KubernetesPodOperator.
2 participants