Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in extra columns to TaskInstance.refresh_from_db #15922

Conversation

leonsmith
Copy link
Contributor

Incorrect values where showing in the TaskInstance detail view because these columns where missing from the refresh_from_db method

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test too

@github-actions
Copy link

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label May 18, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@leonsmith leonsmith force-pushed the add-missing-columns-to-task-instance-refresh branch from 49fa796 to a4ae110 Compare May 24, 2021 17:38
@github-actions
Copy link

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

The Workflow run is cancelling this PR. Building image for the PR has been cancelled

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Jul 17, 2021
@kaxil
Copy link
Member

kaxil commented Jul 22, 2021

Tests are failing @leonsmith

https://github.com/apache/airflow/pull/15922/checks?check_run_id=2663074502#step:6:11941

          for column in columns:
  >           assert getattr(ti, column.name) != 'NOT_REFRESHED'
  E           AssertionError: assert 'NOT_REFRESHED' != 'NOT_REFRESHED'
  E            +  where 'NOT_REFRESHED' = getattr(<TaskInstance: test_refresh_from_db.op 2021-05-25 08:19:00.840850+00:00 [None]>, 'start_date')
  E            +    where 'start_date' = Column('start_date', UtcDateTime(timezone=True), table=<task_instance>).name
  

@kaxil kaxil removed full tests needed We need to run full set of tests for this PR to merge stale Stale PRs per the .github/workflows/stale.yml policy file labels Jul 22, 2021
@ashb
Copy link
Member

ashb commented Jul 28, 2021

I think #17179 does the same thing in a slightly different way.

@ashb ashb closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants