New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid passing aws_conn_id
as conn_args for psycopg2.connect
#16100
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
@gabrielsyapse Hi thanks for the contribution! The change looks fine to me, but it seems that this's more a problem on the usage than the actual code itself. - |
@ xinbinhuang thanks for the reply, line 48-52 of this file documents the usage. also it was working previously in airflow 1.x
|
@gabrielsyapse ah you're right! Would you mind also adding a test case here? This can help us avoid this from happening again in the future. |
aws_conn_id
as conn_args for p
aws_conn_id
as conn_args for paws_conn_id
as conn_args for psycopg2.connect
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
@gabrielsyapse can you try rebasing and then running the pre-commit checks on this? That should address the failing static check https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst |
Awesome work, congrats on your first merged pull request! |
aws_conn_id
should be removed from conn_args and not passed to psycopg2.connectaws_conn_id
is an unknown param to postgres