Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail to log if we can't redact something #16118

Merged
merged 1 commit into from Jun 7, 2021

Conversation

@ashb
Copy link
Member

@ashb ashb commented May 27, 2021

Rather than dying with an exception, catch it and warn about that, asking users to report it to us.

Closes #16071 in the general case, and in the specific write-only IO object that caused the exception.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@ashb ashb requested review from jhtimmins, kaxil and potiuk May 27, 2021
@ashb ashb added this to the Airflow 2.1.1 milestone May 27, 2021
@ashb
Copy link
Member Author

@ashb ashb commented May 27, 2021

potiuk
potiuk approved these changes May 27, 2021
Copy link
Member

@potiuk potiuk left a comment

Nice. Redacting NonRedactable!

@github-actions
Copy link

@github-actions github-actions bot commented May 27, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@madison-ookla
Copy link
Contributor

@madison-ookla madison-ookla commented May 27, 2021

Awesome, thanks @ashb!

kaxil
kaxil approved these changes May 27, 2021
@ashb ashb force-pushed the log-masking-non-str-args branch from 9763858 to ed7cc4e Jun 1, 2021
Rather than dying with an exception, catch it and warn about that,
asking users to report it to us.

Additionally handle the specific case where a file handle/IO object is
logged -- we definitely don't want to iterate over that!
@ashb ashb force-pushed the log-masking-non-str-args branch from ed7cc4e to 3bf83df Jun 5, 2021
@ashb ashb merged commit 57bd6fb into apache:main Jun 7, 2021
43 of 48 checks passed
@ashb ashb deleted the log-masking-non-str-args branch Jun 7, 2021
jhtimmins added a commit that referenced this issue Jun 10, 2021
Rather than dying with an exception, catch it and warn about that,
asking users to report it to us.

Additionally handle the specific case where a file handle/IO object is
logged -- we definitely don't want to iterate over that!

(cherry picked from commit 57bd6fb)
jhtimmins added a commit to astronomer/airflow that referenced this issue Jun 15, 2021
Rather than dying with an exception, catch it and warn about that,
asking users to report it to us.

Additionally handle the specific case where a file handle/IO object is
logged -- we definitely don't want to iterate over that!

(cherry picked from commit 57bd6fb)
ashb added a commit that referenced this issue Jun 22, 2021
Rather than dying with an exception, catch it and warn about that,
asking users to report it to us.

Additionally handle the specific case where a file handle/IO object is
logged -- we definitely don't want to iterate over that!

(cherry picked from commit 57bd6fb)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 22, 2021
Rather than dying with an exception, catch it and warn about that,
asking users to report it to us.

Additionally handle the specific case where a file handle/IO object is
logged -- we definitely don't want to iterate over that!

(cherry picked from commit 57bd6fb)
(cherry picked from commit 7603ef6)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 23, 2021
Rather than dying with an exception, catch it and warn about that,
asking users to report it to us.

Additionally handle the specific case where a file handle/IO object is
logged -- we definitely don't want to iterate over that!

(cherry picked from commit 57bd6fb)
(cherry picked from commit 7603ef6)
(cherry picked from commit 41ae709)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 23, 2021
Rather than dying with an exception, catch it and warn about that,
asking users to report it to us.

Additionally handle the specific case where a file handle/IO object is
logged -- we definitely don't want to iterate over that!

(cherry picked from commit 57bd6fb)
(cherry picked from commit 7603ef6)
(cherry picked from commit 41ae709)
(cherry picked from commit ae0d119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants