Format more dates with timezone #16129
Conversation
Some dates were not being formatted based on the user-selected timezone. This will check for the dag, task, and dag details pages. Also, on the task page, we can check for http strings and turn them into links
boring-cyborg
bot
added
area:UI
add a classname to areas we want to format with the timezone and will be updated whenever the timezone select changes value
There was a problem hiding this comment.
Overall looks good. One request—I've been attempting to introduce this js- prefix pattern anywhere classes are needed as selectors. It makes it clear that they are not for styling purpose (nor should they be used for both) when you encounter a class name in an HTML file.
|
@ryanahamilton good call. It's all updated now. |
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
A bunch of dates in the UI were not being formatted with the user's selected timezone from the dropdown in top navigation. I went through and updated as many as I could find.
Closes: #9221
One exception, for some reason, the task instance start date had an explicit comment to not format it, https://github.com/apache/airflow/blame/10ed42a837e11d8e954c1f885e289a4248edd2ca/airflow/www/static/js/task_instances.js#L82, @ashb should that remain the case?
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.