Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins docutils to <0.17 until breaking behaviour is fixed #16133

Merged
merged 1 commit into from May 28, 2021

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented May 28, 2021

Sphinx RTD theme 0.5.2. introduced limitation to docutils to account for
some docutils markup change:

readthedocs/sphinx_rtd_theme#1112


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Sphinx RTD theme 0.5.2. introduced limitation to docutils to account for
some docutils markup change:

readthedocs/sphinx_rtd_theme#1112
@potiuk potiuk requested a review from kaxil May 28, 2021
@potiuk
Copy link
Member Author

@potiuk potiuk commented May 28, 2021

cc: @uranusjr

@github-actions
Copy link

@github-actions github-actions bot commented May 28, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk
Copy link
Member Author

@potiuk potiuk commented May 28, 2021

close/reopen to rebuild 😠 .... I have to find a fix for this!

@potiuk potiuk closed this May 28, 2021
@potiuk potiuk reopened this May 28, 2021
kaxil
kaxil approved these changes May 28, 2021
@potiuk potiuk merged commit 6fd9c01 into apache:master May 28, 2021
75 of 83 checks passed
@potiuk potiuk deleted the pin-docutils branch May 28, 2021
andormarkus pushed a commit to andormarkus/airflow that referenced this issue Jun 5, 2021
Sphinx RTD theme 0.5.2. introduced limitation to docutils to account for
some docutils markup change:

readthedocs/sphinx_rtd_theme#1112
potiuk added a commit to potiuk/airflow that referenced this issue Jun 22, 2021
Sphinx RTD theme 0.5.2. introduced limitation to docutils to account for
some docutils markup change:

readthedocs/sphinx_rtd_theme#1112
(cherry picked from commit 6fd9c01)
@jedcunningham jedcunningham added this to the Airflow 2.1.1 milestone Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants