Clean Markdown with dedent to respect indents #16414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
approved these changes
Jun 13, 2021
|
@uranusjr Can you create a Github Issue to switch the markdown library to markdown-it-py ? :) |
|
Done in #16435. |
ashb
pushed a commit
that referenced
this pull request
Jun 22, 2021
(cherry picked from commit 6f9c0ce)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #16263, close #16138.
Note that the current Markdown engine does not support fenced code blocks, so it still won’t work after this change. Python-Markdown’s fenced code support is pretty spotty, and if we want to fix that for good IMO we should switch to another Markdown parser. markdown-it-py (the parser backing MyST) is a popular choice for CommonMark support, which is much closer to GitHub-Flavored Markdown which almost everyone thinks is the standard Markdown (which is unfortunately because GFM is not standard, but that’s how the world works).