Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability for Snowflake to attribute usage to Airflow by adding an application parameter #16420

Merged
merged 8 commits into from Jun 15, 2021
Merged

Added ability for Snowflake to attribute usage to Airflow by adding an application parameter #16420

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e3c56ec
Added snowflake tags for consumption tracking
sfc-gh-madkins Jun 13, 2021
1fd6e3c
Merge branch 'apache:main' into master
sfc-gh-madkins Jun 13, 2021
24076c2
excess space clean up
sfc-gh-madkins Jun 13, 2021
6af34e9
Merge branch 'master' of github.com:sfc-gh-madkins/airflow
sfc-gh-madkins Jun 13, 2021
26b344f
fixup! Merge branch 'master' of github.com:sfc-gh-madkins/airflow
kaxil Jun 14, 2021
2ca7067
Revised snowflake application tag to be static and not exposed to the…
sfc-gh-madkins Jun 14, 2021
ed4b7e4
Updated applicaton parameter to search environment variables first
sfc-gh-madkins Jun 15, 2021
e326075
Update airflow/providers/snowflake/hooks/snowflake.py
potiuk Jun 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions airflow/providers/snowflake/hooks/snowflake.py
View file
Open in desktop
Expand Up @@ -179,6 +179,7 @@ def _get_conn_params(self) -> Dict[str, Optional[str]]:
"role": self.role or role,
"authenticator": self.authenticator or authenticator,
"session_parameters": self.session_parameters or session_parameters,
"application": "AIRFLOW",
Copy link
Member

@kaxil kaxil Jun 14, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping we could use: AIRFLOW_SNOWFLAKE_PARTNER or a similar environment variable so even the partners don't need to change the provider, what do you think?

Example:

Suggested change
"application": "AIRFLOW",
"application": os.environ.get("AIRFLOW_SNOWFLAKE_PARTNER", "AIRFLOW"),

So it default to AIRFLOW and your partners just need to add that Environment variable in their image, example:

AIRFLOW_SNOWFLAKE_PARTNER=AWS

or

AIRFLOW_SNOWFLAKE_PARTNER=Astronomer

or

AIRFLOW_SNOWFLAKE_PARTNER=GCP

}

# If private_key_file is specified in the extra json, load the contents of the file as a private
Expand Down