fix: change graph focus to top of view instead of center #16484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
ryanahamilton
approved these changes
Jun 16, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Jun 22, 2021
(cherry picked from commit f167585)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 9, 2021
(cherry picked from commit f167585)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 13, 2021
(cherry picked from commit f167585)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
(cherry picked from commit f167585)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
(cherry picked from commit f167585)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When expanding/collapsing a group. We originally set the focus to the center of the graph view renderable area. But that isn't the center of the screen and often times the renderable area requires you to scroll down. This PR changes the focus to the top of the graph view so it appears clearly without the need to scroll.
Closes #16359
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.