Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree View UI for larger DAGs & more consistent spacing in Tree View #16522

Merged
merged 2 commits into from Jun 21, 2021

Conversation

@freget
Copy link
Contributor

@freget freget commented Jun 18, 2021

closes: #16238

Currently, the space available for the tree and operator names in the tree view is calculated by substracting a quite a few things from the screen width. This does not really make sense. It would be better to calculate the required width of the tree and add some more for operator names.

This PR makes a suggestion accordingly.

Note: It might be even better to calculate the required width for operator names dynamically.

@freget
Copy link
Contributor Author

@freget freget commented Jun 20, 2021

@bbovenzi Maybe you can have a look.

airflow/www/static/js/tree.js Outdated Show resolved Hide resolved
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Copy link
Contributor

@bbovenzi bbovenzi left a comment

lgtm

@jhtimmins jhtimmins added this to the Airflow 2.1.1 milestone Jun 21, 2021
@ryanahamilton ryanahamilton merged commit f9786d4 into apache:main Jun 21, 2021
26 of 28 checks passed
@boring-cyborg
Copy link

@boring-cyborg boring-cyborg bot commented Jun 21, 2021

Awesome work, congrats on your first merged pull request!

@freget freget deleted the fix_16238 branch Jun 21, 2021
jhtimmins added a commit to astronomer/airflow that referenced this issue Jun 22, 2021
…pache#16522)

* Made squareX independent of screen width

* Removed now unnecessary variable innerWidth.

Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>

Co-authored-by: Schneider, Thilo <t.schneider3@fraport.de>
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
(cherry picked from commit f9786d4)
ashb added a commit that referenced this issue Jun 22, 2021
…16522)

* Made squareX independent of screen width

* Removed now unnecessary variable innerWidth.

Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>

Co-authored-by: Schneider, Thilo <t.schneider3@fraport.de>
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
(cherry picked from commit f9786d4)
kaxil added a commit to astronomer/airflow that referenced this issue Jun 22, 2021
…pache#16522)

* Made squareX independent of screen width

* Removed now unnecessary variable innerWidth.

Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>

Co-authored-by: Schneider, Thilo <t.schneider3@fraport.de>
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
(cherry picked from commit f9786d4)
(cherry picked from commit 215492d)
Jorricks added a commit to Jorricks/airflow that referenced this issue Jun 24, 2021
…pache#16522)

* Made squareX independent of screen width

* Removed now unnecessary variable innerWidth.

Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>

Co-authored-by: Schneider, Thilo <t.schneider3@fraport.de>
Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants