-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API endpoint to create new user #16609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also think that the Patch/Delete endpoint should be added alongside this endpoint to make a complete CUD
Indeed, I’m already working on PATCH and DELETE, but want to post this first since it’s more or less standalone, and after this the rest is very straightforward. If it’s desired, I can continue to push to this PR instead. |
Yep. Pushing here is cool in my opinion |
8facd3a
to
e5ed366
Compare
I’ve added PATCH and DELETE, but left out the |
aa2260a
to
e98aef9
Compare
Please rebase on main since pylint is removed now :) |
e98aef9
to
cd545fc
Compare
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.