Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API endpoint to create new user #16609

Merged
merged 4 commits into from
Jul 22, 2021
Merged

Conversation

uranusjr
Copy link
Member


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jun 23, 2021
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 23, 2021
Copy link
Contributor

@ephraimbuddy ephraimbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think that the Patch/Delete endpoint should be added alongside this endpoint to make a complete CUD

@uranusjr
Copy link
Member Author

Indeed, I’m already working on PATCH and DELETE, but want to post this first since it’s more or less standalone, and after this the rest is very straightforward. If it’s desired, I can continue to push to this PR instead.

@ephraimbuddy
Copy link
Contributor

Indeed, I’m already working on PATCH and DELETE, but want to post this first since it’s more or less standalone, and after this the rest is very straightforward. If it’s desired, I can continue to push to this PR instead.

Yep. Pushing here is cool in my opinion

@uranusjr
Copy link
Member Author

I’ve added PATCH and DELETE, but left out the AUTH_USER_REGISTRATION check. The documentation says it toggles self registration, but this API is intended to be used by admins to create a user, not for new users to create themselves. So the endpoint shouldn’t be disabled by the configuration IMO.

@uranusjr uranusjr force-pushed the connexion-user-role-assign branch 2 times, most recently from aa2260a to e98aef9 Compare June 24, 2021 02:33
@kaxil
Copy link
Member

kaxil commented Jul 1, 2021

Please rebase on main since pylint is removed now :)

@uranusjr uranusjr force-pushed the connexion-user-role-assign branch from e98aef9 to cd545fc Compare July 2, 2021 09:21
@kaxil kaxil closed this Jul 22, 2021
@kaxil kaxil reopened this Jul 22, 2021
@kaxil kaxil added this to the Airflow 2.2 milestone Jul 22, 2021
@kaxil kaxil merged commit 1759288 into apache:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants