Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Add more clear docs for setting pod_template_file.yaml #16632

Merged
merged 1 commit into from Jun 24, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jun 24, 2021

The values.yaml didn't have any docs on it.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

The values.yaml didn't have any docs on it.
@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jun 24, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 24, 2021
@kaxil kaxil merged commit 962c5f4 into apache:main Jun 24, 2021
@kaxil kaxil deleted the improve-doc-chart branch June 24, 2021 12:54
@kaxil
Copy link
Member Author

kaxil commented Jun 24, 2021

Ran locally:

#################### Documentation will be built for 1 package(s) with 6 parallel jobs ####################
1. helm-chart
#################### Cleaning documentation files ####################
helm-chart                                                  : Cleaning files
#################### Scheduling documentation to build ####################
helm-chart                                                  : Scheduling documentation to build
#################### Running docs building ####################

helm-chart                                                  : Building documentation
helm-chart                                                  : Running sphinx. The output is hidden until an error occurs.
helm-chart                                                  : Finished docs building successfully
#################### Scheduling spell checking of documentation ####################
helm-chart                                                  : Scheduling spellchecking
#################### Running spell checking of documentation ####################

helm-chart                                                  : Checking spelling started
helm-chart                                                  : Finished spell-checking successfully
helm-chart                                                  : Checking spelling completed
Documentation build is successful

@kaxil kaxil added this to the Airflow Helm Chart 1.1.0 milestone Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants