-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set process title for serve-logs
and LocalExecutor
#16644
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up of apache#16623. This PR/commits adds title to serve-logs command and multiprocessing manager for LocalExecutor. The serve-logs process is on celery worker when using CeleryExecutor but for LocalExecutor, it is a separate process in Scheduler. **Before**: ``` root 124 0.0 0.0 6676 4636 pts/1 Ss Jun23 0:00 \_ -bash root 25299 25.3 2.6 988372 326344 pts/1 Sl+ 01:30 0:09 | \_ /usr/local/bin/python /usr/local/bin/airflow webserver root 25510 3.6 0.4 121068 57152 pts/1 S+ 01:31 0:00 | \_ gunicorn: master [airflow-webserver] root 25555 35.7 2.5 983584 316564 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25556 35.7 2.5 983840 316684 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25557 35.5 2.5 983840 316548 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25558 37.2 2.5 984920 317700 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 128 0.0 0.0 6676 4552 pts/2 Ss Jun23 0:00 \_ -bash root 25090 5.8 0.9 467508 118808 pts/2 S+ 01:30 0:03 \_ /usr/local/bin/python /usr/local/bin/airflow scheduler root 25098 0.0 0.7 466080 97800 pts/2 S+ 01:30 0:00 \_ /usr/local/bin/python /usr/local/bin/airflow scheduler root 25099 0.4 0.8 1391812 99788 pts/2 Sl+ 01:30 0:00 \_ /usr/local/bin/python /usr/local/bin/airflow scheduler root 25107 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25109 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25114 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25117 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25120 0.0 0.8 466080 98552 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25125 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor: ['airflow', 'tasks', 'run', 'example_bash_operator', 'run_after_loop', '2021-06-24T01:31:30.507415+00:00', '--lo root 26139 0.0 0.8 468988 102204 pts/2 S+ 01:31 0:00 | \_ airflow task supervisor: ['airflow', 'tasks', 'run', 'example_bash_operator', 'run_after_loop', '2021-06-24T01:31:30.507415+00:00', '--local' root 25128 0.0 0.7 466080 98076 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25132 0.0 0.7 466080 98076 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25137 1.1 0.8 466592 100016 pts/2 S 01:30 0:00 \_ airflow scheduler -- DagFileProcessorManager root@a7c8aa590704:/opt/airflow# ps aux ``` **After**: ``` root 124 0.0 0.0 6676 4636 pts/1 Ss Jun23 0:00 \_ -bash root 25299 25.3 2.6 988372 326344 pts/1 Sl+ 01:30 0:09 | \_ /usr/local/bin/python /usr/local/bin/airflow webserver root 25510 3.6 0.4 121068 57152 pts/1 S+ 01:31 0:00 | \_ gunicorn: master [airflow-webserver] root 25555 35.7 2.5 983584 316564 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25556 35.7 2.5 983840 316684 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25557 35.5 2.5 983840 316548 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25558 37.2 2.5 984920 317700 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 128 0.0 0.0 6676 4552 pts/2 Ss Jun23 0:00 \_ -bash root 25090 5.8 0.9 467508 118808 pts/2 S+ 01:30 0:03 \_ /usr/local/bin/python /usr/local/bin/airflow scheduler root 25098 0.0 0.7 466080 97800 pts/2 S+ 01:30 0:00 \_ airflow serve-logs root 25099 0.4 0.8 1391812 99788 pts/2 Sl+ 01:30 0:00 \_ airflow executor -- LocalExecutor root 25107 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25109 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25114 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25117 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25120 0.0 0.8 466080 98552 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25125 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor: ['airflow', 'tasks', 'run', 'example_bash_operator', 'run_after_loop', '2021-06-24T01:31:30.507415+00:00', '--lo root 26139 0.0 0.8 468988 102204 pts/2 S+ 01:31 0:00 | \_ airflow task supervisor: ['airflow', 'tasks', 'run', 'example_bash_operator', 'run_after_loop', '2021-06-24T01:31:30.507415+00:00', '--local' root 25128 0.0 0.7 466080 98076 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25132 0.0 0.7 466080 98076 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25137 1.1 0.8 466592 100016 pts/2 S 01:30 0:00 \_ airflow scheduler -- DagFileProcessorManager root@a7c8aa590704:/opt/airflow# ps aux ```
potiuk
approved these changes
Jun 25, 2021
github-actions
bot
added
the
full tests needed
We need to run full set of tests for this PR to merge
label
Jun 25, 2021
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 6, 2021
) Follow up of apache#16623. This PR/commits adds title to serve-logs command and multiprocessing manager for LocalExecutor. The serve-logs process is on celery worker when using CeleryExecutor but for LocalExecutor, it is a separate process in Scheduler. **Before**: ``` root 124 0.0 0.0 6676 4636 pts/1 Ss Jun23 0:00 \_ -bash root 25299 25.3 2.6 988372 326344 pts/1 Sl+ 01:30 0:09 | \_ /usr/local/bin/python /usr/local/bin/airflow webserver root 25510 3.6 0.4 121068 57152 pts/1 S+ 01:31 0:00 | \_ gunicorn: master [airflow-webserver] root 25555 35.7 2.5 983584 316564 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25556 35.7 2.5 983840 316684 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25557 35.5 2.5 983840 316548 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25558 37.2 2.5 984920 317700 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 128 0.0 0.0 6676 4552 pts/2 Ss Jun23 0:00 \_ -bash root 25090 5.8 0.9 467508 118808 pts/2 S+ 01:30 0:03 \_ /usr/local/bin/python /usr/local/bin/airflow scheduler root 25098 0.0 0.7 466080 97800 pts/2 S+ 01:30 0:00 \_ /usr/local/bin/python /usr/local/bin/airflow scheduler root 25099 0.4 0.8 1391812 99788 pts/2 Sl+ 01:30 0:00 \_ /usr/local/bin/python /usr/local/bin/airflow scheduler root 25107 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25109 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25114 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25117 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25120 0.0 0.8 466080 98552 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25125 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor: ['airflow', 'tasks', 'run', 'example_bash_operator', 'run_after_loop', '2021-06-24T01:31:30.507415+00:00', '--lo root 26139 0.0 0.8 468988 102204 pts/2 S+ 01:31 0:00 | \_ airflow task supervisor: ['airflow', 'tasks', 'run', 'example_bash_operator', 'run_after_loop', '2021-06-24T01:31:30.507415+00:00', '--local' root 25128 0.0 0.7 466080 98076 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25132 0.0 0.7 466080 98076 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25137 1.1 0.8 466592 100016 pts/2 S 01:30 0:00 \_ airflow scheduler -- DagFileProcessorManager root@a7c8aa590704:/opt/airflow# ps aux ``` **After**: ``` root 124 0.0 0.0 6676 4636 pts/1 Ss Jun23 0:00 \_ -bash root 25299 25.3 2.6 988372 326344 pts/1 Sl+ 01:30 0:09 | \_ /usr/local/bin/python /usr/local/bin/airflow webserver root 25510 3.6 0.4 121068 57152 pts/1 S+ 01:31 0:00 | \_ gunicorn: master [airflow-webserver] root 25555 35.7 2.5 983584 316564 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25556 35.7 2.5 983840 316684 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25557 35.5 2.5 983840 316548 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 25558 37.2 2.5 984920 317700 pts/1 Sl+ 01:31 0:08 | \_ [ready] gunicorn: worker [airflow-webserver] root 128 0.0 0.0 6676 4552 pts/2 Ss Jun23 0:00 \_ -bash root 25090 5.8 0.9 467508 118808 pts/2 S+ 01:30 0:03 \_ /usr/local/bin/python /usr/local/bin/airflow scheduler root 25098 0.0 0.7 466080 97800 pts/2 S+ 01:30 0:00 \_ airflow serve-logs root 25099 0.4 0.8 1391812 99788 pts/2 Sl+ 01:30 0:00 \_ airflow executor -- LocalExecutor root 25107 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25109 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25114 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25117 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25120 0.0 0.8 466080 98552 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25125 0.0 0.8 466080 98548 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor: ['airflow', 'tasks', 'run', 'example_bash_operator', 'run_after_loop', '2021-06-24T01:31:30.507415+00:00', '--lo root 26139 0.0 0.8 468988 102204 pts/2 S+ 01:31 0:00 | \_ airflow task supervisor: ['airflow', 'tasks', 'run', 'example_bash_operator', 'run_after_loop', '2021-06-24T01:31:30.507415+00:00', '--local' root 25128 0.0 0.7 466080 98076 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25132 0.0 0.7 466080 98076 pts/2 S+ 01:30 0:00 \_ airflow worker -- LocalExecutor root 25137 1.1 0.8 466592 100016 pts/2 S 01:30 0:00 \_ airflow scheduler -- DagFileProcessorManager root@a7c8aa590704:/opt/airflow# ps aux ``` (cherry picked from commit 1b2535e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:Scheduler
Scheduler or dag parsing Issues
full tests needed
We need to run full set of tests for this PR to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #16623.
This PR/commits adds title to serve-logs command and multiprocessing
manager for LocalExecutor.
The serve-logs process is on celery worker when using CeleryExecutor but
for LocalExecutor, it is a separate process in Scheduler.
Before:
After:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.