Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New generic tableau operator: TableauOperator #16915

Merged
merged 44 commits into from
Aug 9, 2021
Merged

New generic tableau operator: TableauOperator #16915

merged 44 commits into from
Aug 9, 2021

Conversation

mariotaddeucci
Copy link
Contributor

Added an generic tableau operator to execute multiple methods on python client.

Added generic tableau operator to execute multiple methods on python client
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 9, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comments in the code.
Note that also requires tests for TableauOperator

airflow/providers/tableau/operators/tableau.py Outdated Show resolved Hide resolved
- Fixed documentation comments on TableauOperator execute
- Added generic find by column
- Deprecated TableauRefreshWorkbookOperator
@mariotaddeucci
Copy link
Contributor Author

@eladkal I adapt the tests from TableauRefreshWorkbookOperator and the tests from PR #16937

airflow/providers/tableau/operators/tableau.py Outdated Show resolved Hide resolved
airflow/providers/tableau/provider.yaml Show resolved Hide resolved
airflow/providers/tableau/operators/tableau.py Outdated Show resolved Hide resolved
@eladkal
Copy link
Contributor

eladkal commented Jul 15, 2021

@mariotaddeucci we just merged #16916 can you please rebase and fix conflicts?

@mariotaddeucci
Copy link
Contributor Author

mariotaddeucci commented Aug 3, 2021

@eladkal @potiuk the unit tests have run successfully now ✅

@potiuk
Copy link
Member

potiuk commented Aug 4, 2021

Static checks and docs are still failing I am afraid.

@mariotaddeucci
Copy link
Contributor Author

mariotaddeucci commented Aug 8, 2021

@eladkal the last commit haven't passed on on CI Build / Build and test provider packages wheel because pypsrc on Microsoft provider and wasn't caused by this PR. Is there anything else that this PR needs?

@potiuk
Copy link
Member

potiuk commented Aug 8, 2021

New dependency was added by new provider and you need to rebase to get it working I am afraid :)

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (left one comment on but it's not that important)

@github-actions
Copy link

github-actions bot commented Aug 8, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Aug 8, 2021
@potiuk potiuk merged commit 5df99d6 into apache:main Aug 9, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 9, 2021

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Aug 9, 2021

Woohoo!

@mariotaddeucci
Copy link
Contributor Author

Thanks all for supporting me on this PR @eladkal @potiuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants