Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve executor validation in CLI #17071

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Conversation

mik-laj
Copy link
Member

@mik-laj mik-laj commented Jul 19, 2021

Previously, when a user tried to check configurations for celery, they got a message that the celery SUBCOMMAND is not supported. This is confusing as user was running config get-value and not celery *.

airflow config get-value celery broker-url
usage: airflow config get-value [-h] section option

Print the value of the configuration

positional arguments:
  section     The section name
  option      The option name

optional arguments:
  -h, --help  show this help message and exit

airflow config get-value command error: argument section: celery subcommand works only with CeleryExecutor, your current executor: LocalExecutor, see help above.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jul 19, 2021
@mik-laj mik-laj merged commit 1e2837a into apache:main Jul 19, 2021
@mik-laj mik-laj deleted the executor-validation branch July 19, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants