Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show serialization exceptions in DAG parsing log #17277

Merged
merged 1 commit into from Jul 28, 2021

Conversation

jedcunningham
Copy link
Member

@jedcunningham jedcunningham commented Jul 27, 2021

Make sure that any exceptions that happen when writing serialized DAGs
to the db get written to the DAG parsing log, instead of only being added
to import_errors for consumption via the UI.

related: #17166

Make sure that any exceptions that happen when writing serialized DAGs
to the db get written to the DAG parsing log, instead of only being added
to `import_errors` for consumption via the UI.
@jedcunningham jedcunningham added this to the Airflow 2.1.3 milestone Jul 27, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jul 27, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr uranusjr closed this Jul 28, 2021
@uranusjr
Copy link
Member

Is this stuck?

@uranusjr uranusjr reopened this Jul 28, 2021
@kaxil
Copy link
Member

kaxil commented Jul 28, 2021

Yea looks like some CI issue

@jedcunningham jedcunningham reopened this Jul 28, 2021
@jedcunningham jedcunningham merged commit 9cd5a97 into apache:main Jul 28, 2021
@jedcunningham jedcunningham deleted the log_serialization_errors branch July 28, 2021 16:51
jhtimmins pushed a commit that referenced this pull request Aug 9, 2021
Make sure that any exceptions that happen when writing serialized DAGs
to the db get written to the DAG parsing log, instead of only being added
to `import_errors` for consumption via the UI.

(cherry picked from commit 9cd5a97)
jhtimmins pushed a commit that referenced this pull request Aug 13, 2021
Make sure that any exceptions that happen when writing serialized DAGs
to the db get written to the DAG parsing log, instead of only being added
to `import_errors` for consumption via the UI.

(cherry picked from commit 9cd5a97)
kaxil pushed a commit that referenced this pull request Aug 17, 2021
Make sure that any exceptions that happen when writing serialized DAGs
to the db get written to the DAG parsing log, instead of only being added
to `import_errors` for consumption via the UI.

(cherry picked from commit 9cd5a97)
jhtimmins pushed a commit that referenced this pull request Aug 17, 2021
Make sure that any exceptions that happen when writing serialized DAGs
to the db get written to the DAG parsing log, instead of only being added
to `import_errors` for consumption via the UI.

(cherry picked from commit 9cd5a97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants