New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show serialization exceptions in DAG parsing log #17277
Merged
jedcunningham
merged 1 commit into
apache:main
from
astronomer:log_serialization_errors
Jul 28, 2021
Merged
Show serialization exceptions in DAG parsing log #17277
jedcunningham
merged 1 commit into
apache:main
from
astronomer:log_serialization_errors
Jul 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that any exceptions that happen when writing serialized DAGs to the db get written to the DAG parsing log, instead of only being added to `import_errors` for consumption via the UI.
kaxil
approved these changes
Jul 27, 2021
github-actions
bot
added
the
full tests needed
We need to run full set of tests for this PR to merge
label
Jul 27, 2021
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Is this stuck? |
uranusjr
approved these changes
Jul 28, 2021
Yea looks like some CI issue |
potiuk
approved these changes
Jul 28, 2021
jhtimmins
pushed a commit
that referenced
this pull request
Aug 9, 2021
Make sure that any exceptions that happen when writing serialized DAGs to the db get written to the DAG parsing log, instead of only being added to `import_errors` for consumption via the UI. (cherry picked from commit 9cd5a97)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 13, 2021
Make sure that any exceptions that happen when writing serialized DAGs to the db get written to the DAG parsing log, instead of only being added to `import_errors` for consumption via the UI. (cherry picked from commit 9cd5a97)
kaxil
pushed a commit
that referenced
this pull request
Aug 17, 2021
Make sure that any exceptions that happen when writing serialized DAGs to the db get written to the DAG parsing log, instead of only being added to `import_errors` for consumption via the UI. (cherry picked from commit 9cd5a97)
jhtimmins
pushed a commit
that referenced
this pull request
Aug 17, 2021
Make sure that any exceptions that happen when writing serialized DAGs to the db get written to the DAG parsing log, instead of only being added to `import_errors` for consumption via the UI. (cherry picked from commit 9cd5a97)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that any exceptions that happen when writing serialized DAGs
to the db get written to the DAG parsing log, instead of only being added
to
import_errors
for consumption via the UI.related: #17166