Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart: Add instructions to Update Helm Repo before upgrade #17282

Merged
merged 1 commit into from
Jul 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions chart/UPDATING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ assists users migrating to a new version.
Airflow Helm Chart 1.1.0
------------------------

Run ``helm repo update`` before upgrading the chart to the latest version.

Default Airflow version is updated to ``2.1.2``
"""""""""""""""""""""""""""""""""""""""""""""""

Expand Down
22 changes: 16 additions & 6 deletions dev/README_RELEASE_HELM_CHART.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
- [Update `index.yaml` to Airflow Website](#update-indexyaml-to-airflow-website)
- [Notify developers of release](#notify-developers-of-release)
- [Update Announcements page](#update-announcements-page)
- [Remove old releases](#remove-old-releases)

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

Expand Down Expand Up @@ -490,12 +491,6 @@ for f in ../../../airflow-dev/helm-chart/$RC/*; do svn cp $f ${$(basename $f)/};
svn rm index.yaml
svn commit -m "Release Airflow Helm Chart Check ${VERSION} from ${RC}"

# Remove old release
# http://www.apache.org/legal/release-policy.html#when-to-archive
cd ..
export PREVIOUS_VERSION=1.0.0
svn rm ${PREVIOUS_VERSION}
svn commit -m "Remove old Helm Chart release: ${PREVIOUS_VERSION}"
```

Verify that the packages appear in [Airflow Helm Chart](https://dist.apache.org/repos/dist/release/airflow/helm-chart/).
Expand Down Expand Up @@ -590,3 +585,18 @@ EOF
## Update Announcements page

Update "Announcements" page at the [Official Airflow website](https://airflow.apache.org/announcements/)

## Remove old releases

We should keep the old version a little longer than a day or at least until the updated
``index.yaml`` is published. This is to avoid errors for users who haven't run ``helm repo update``.

It is probably ok if we leave last 2 versions on release svn repo too.

```shell
# http://www.apache.org/legal/release-policy.html#when-to-archive
cd airflow-release/helm-chart
export PREVIOUS_VERSION=1.0.0
svn rm ${PREVIOUS_VERSION}
svn commit -m "Remove old Helm Chart release: ${PREVIOUS_VERSION}"
```
3 changes: 3 additions & 0 deletions docs/helm-chart/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ To upgrade the chart with the release name ``airflow``:

helm upgrade airflow apache-airflow/airflow --namespace airflow

.. note::
To upgrade to a new version of the chart, run ``helm repo update`` first.

Uninstalling the Chart
----------------------

Expand Down