Adding support for multiple task-ids in the external task sensor #17339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:core-operators
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
sreenath-kamath
changed the title
sreenath-kamath
force-pushed
the
issue-16705
branch
from
0646a5d
to
8974753
Compare
|
@potiuk can you please help assign reviewers for the PR |
sreenath-kamath
force-pushed
the
issue-16705
branch
from
8974753
to
185bd74
Compare
potiuk
reviewed
Jul 30, 2021
potiuk
reviewed
Aug 1, 2021
airflow/sensors/external_task.py
Outdated
| @@ -149,7 +167,10 @@ def poke(self, context, session=None): | |||
| serialized_dttm_filter = ','.join(dt.isoformat() for dt in dttm_filter) | |||
|
|
|||
| self.log.info( | |||
| 'Poking for %s.%s on %s ... ', self.external_dag_id, self.external_task_id, serialized_dttm_filter | |||
| 'Poking for %s.%s on %s ... ', | |||
There was a problem hiding this comment.
Nit: I think this will look rather weird when there is one task (Poking for dag.[task1] on "filter"). Maybe "Poking for tasks: ['task1' ,'task2'] in dag: dag".
There was a problem hiding this comment.
Yup makes sense, Have modified the logging statement and added a test case to validate the same.
sreenath-kamath
force-pushed
the
issue-16705
branch
from
185bd74
to
986d536
Compare
|
@potiuk Have made the recommended changes, Can you take another pass at it ? |
sreenath-kamath
force-pushed
the
issue-16705
branch
from
a6c2690
to
029c5b1
Compare
potiuk
approved these changes
Aug 19, 2021
|
Awesome work, congrats on your first merged pull request! |
|
Sorry it took so long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for multiple task-ids in the external task sensor
closes: #16705