Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Celery 5 #17397

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Update to Celery 5 #17397

merged 1 commit into from
Aug 27, 2021

Conversation

jedcunningham
Copy link
Member

@jedcunningham jedcunningham added the area:Scheduler Scheduler or dag parsing Issues label Aug 3, 2021
@jedcunningham jedcunningham added this to the Airflow 2.2 milestone Aug 3, 2021
Dockerfile.ci Outdated Show resolved Hide resolved
@potiuk potiuk marked this pull request as ready for review August 7, 2021 09:09
@potiuk potiuk requested a review from ashb as a code owner August 7, 2021 09:09
@potiuk
Copy link
Member

potiuk commented Aug 7, 2021

Ah sorry by accident marked it as ready for review

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asumming tests pass…

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Aug 11, 2021
@uranusjr uranusjr closed this Aug 18, 2021
@uranusjr uranusjr reopened this Aug 18, 2021
ashb
ashb previously requested changes Aug 18, 2021
setup.py Outdated Show resolved Hide resolved
@potiuk
Copy link
Member

potiuk commented Aug 18, 2021

Shall I take a look at the deps ? tomorrow I might have some time :)

@jedcunningham
Copy link
Member Author

@potiuk, have at it. I've not made any progress over the last few days.

@jedcunningham
Copy link
Member Author

Shout out to @uranusjr for identifying the conflicting package! Ready for more eyes.

Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff @jedcunningham @uranusjr -- we needed this since some time now

@potiuk
Copy link
Member

potiuk commented Aug 27, 2021

Oh yeah! Good stuff @uranusjr with the conflict :). This is yet another example where I am waiting for new PIP releases to show the conflicts better :). You need to automate your investigative skills there!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:Scheduler Scheduler or dag parsing Issues full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Celery 5.0
5 participants