Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation notice for SubDagOperator #17488

Merged
merged 1 commit into from
Aug 8, 2021
Merged

add deprecation notice for SubDagOperator #17488

merged 1 commit into from
Aug 8, 2021

Conversation

eladkal
Copy link
Contributor

@eladkal eladkal commented Aug 7, 2021

Adding deprecation notice for SubDagOperator
closes: #12292
The mailing list discussion was before Airflow 2 was released. I think we have a good adoption of TasksGroup however
I see users that are on Airflow 2 who still write new DAGs with SubDagOperator (Not sure why)

We know the general direction is to replace SubDagOperator with TasksGroup so I think we should place a deprecation notice.

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@eladkal eladkal requested review from potiuk and kaxil August 7, 2021 18:48
@boring-cyborg boring-cyborg bot added the area:core-operators Operators, Sensors and hooks within Core Airflow label Aug 7, 2021
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Task Group does not (yet) provide full replacement to SubDag, but maybe that's good to deprecate it now to get all the uses from users.

@eladkal
Copy link
Contributor Author

eladkal commented Aug 7, 2021

I think Task Group does not (yet) provide full replacement to SubDag, but maybe that's good to deprecate it now to get all the uses from users.

Yes this is what I had in mind.
We don't have to remove SubDagOperator in airflow 3 but we do want people to know that the feature is deprecated.

@github-actions
Copy link

github-actions bot commented Aug 7, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Aug 7, 2021
@eladkal eladkal added this to the Airflow 2.2 milestone Aug 7, 2021
@eladkal eladkal requested a review from turbaszek August 8, 2021 07:41
@eladkal eladkal removed the full tests needed We need to run full set of tests for this PR to merge label Aug 8, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Aug 8, 2021
@github-actions
Copy link

github-actions bot commented Aug 8, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core-operators Operators, Sensors and hooks within Core Airflow full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate SubDags in Favor of TaskGroups
3 participants