Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add FAQ to speed up parsing with tons of dag files #17519

Merged
merged 1 commit into from Aug 10, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Aug 10, 2021

This feature was added in #16075. This PR adds it to docs to avoid situations like #17437

closes #17437


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@jedcunningham
Copy link
Member

Might be worth mentioning this only helps with "simple" DAGs, e.g. if the main DAG file itself actually changes. Not sure exactly how to phrase it in this context, but this won't always be a safe option.

@@ -119,6 +119,18 @@ How do I trigger tasks based on another task's failure?

You can achieve this with :ref:`concepts:trigger-rules`.

When there are a lot of dags files, how to speed up parsing of new files?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be more specific to what is a lot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

This feature was added in apache#16075. This PR adds it to docs to avoid situations like apache#17437

closes apache#17437
@kaxil
Copy link
Member Author

kaxil commented Aug 10, 2021

Might be worth mentioning this only helps with "simple" DAGs, e.g. if the main DAG file itself actually changes. Not sure exactly how to phrase it in this context, but this won't always be a safe option.

Updated

@kaxil kaxil requested a review from eladkal August 10, 2021 09:46
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Aug 10, 2021
@github-actions
Copy link

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil merged commit 7dfc520 into apache:main Aug 10, 2021
@kaxil kaxil deleted the doc-faq-parsing branch August 10, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:documentation okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's too slow to recognize new dag file when there are a log of dags files
3 participants