Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the broken json_client #17529

Merged
merged 1 commit into from Aug 10, 2021
Merged

Fixed the broken json_client #17529

merged 1 commit into from Aug 10, 2021

Conversation

sw1010
Copy link
Contributor

@sw1010 sw1010 commented Aug 10, 2021

The json_client depends on httpx and thus the response doesn't contain
the attribute 'ok'. To fix the problem, the missing attribute has been changed
to is_error.

closes: #17527

The json_client depends on httpx and thus the response doesn't contain
the attribute 'ok'. In consequence, the missing attribute has been changed
to is_error.
@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Aug 10, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 10, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Aug 10, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil merged commit fbddefe into apache:main Aug 10, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 10, 2021

Awesome work, congrats on your first merged pull request!

@kaxil kaxil added this to the Airflow 2.1.3 milestone Aug 10, 2021
jhtimmins pushed a commit that referenced this pull request Aug 12, 2021
The json_client depends on httpx and thus the response doesn't contain
the attribute 'ok'. In consequence, the missing attribute has been changed
to is_error.

closes: #17527

Co-authored-by: Szymon Wojciechowski <szymon.wojciechowski@here.com>
(cherry picked from commit fbddefe)
jhtimmins pushed a commit that referenced this pull request Aug 13, 2021
The json_client depends on httpx and thus the response doesn't contain
the attribute 'ok'. In consequence, the missing attribute has been changed
to is_error.

closes: #17527

Co-authored-by: Szymon Wojciechowski <szymon.wojciechowski@here.com>
(cherry picked from commit fbddefe)
kaxil pushed a commit that referenced this pull request Aug 17, 2021
The json_client depends on httpx and thus the response doesn't contain
the attribute 'ok'. In consequence, the missing attribute has been changed
to is_error.

closes: #17527

Co-authored-by: Szymon Wojciechowski <szymon.wojciechowski@here.com>
(cherry picked from commit fbddefe)
jhtimmins pushed a commit that referenced this pull request Aug 17, 2021
The json_client depends on httpx and thus the response doesn't contain
the attribute 'ok'. In consequence, the missing attribute has been changed
to is_error.

closes: #17527

Co-authored-by: Szymon Wojciechowski <szymon.wojciechowski@here.com>
(cherry picked from commit fbddefe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken json_client
4 participants