Fixed long delays never returning in DateTimeTrigger #17564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewgodwin
changed the title
This trigger was never actually working for delays over two hours, as it was comparing a Pendulum.Period to a datetime.datetime, in a way that always returned True. This commit fixes the behaviour. This unfortunately seems un-testable, as it's not possible to interrupt asyncio's sleep() while it's in-flight.
andrewgodwin
force-pushed
the
fix_temporal_trigger
branch
from
2ab8953
to
c7d4dc5
Compare
jedcunningham
approved these changes
Aug 12, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
kaxil
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trigger was never actually firing for delays over two hours, as it was comparing a Pendulum.Period to a datetime.datetime, in a way that always returned
Truefor certain dates (especially those a long time in the past).This commit fixes the behaviour. This unfortunately seems un-testable, as it's not possible to interrupt asyncio's sleep() while it's in-flight.