Fix triggerer query where limit is not supported in some DB versions #17601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
added
the
full tests needed
ephraimbuddy
force-pushed
the
fix-triggerer-query
branch
2 times, most recently
from
7caa5e6
to
491bb87
Compare
ephraimbuddy
changed the title
|
cc: @andrewgodwin |
andrewgodwin
suggested changes
Aug 13, 2021
ephraimbuddy
force-pushed
the
fix-triggerer-query
branch
from
491bb87
to
2a4373f
Compare
This PR fixes the triggerrer query where limit is not supported in some DB version Fix test_temporal and sqlite test too fixup! Fix test_temporal and sqlite test too fixup! Fix triggerer query where limit is not supported in some Mysql version
andrewgodwin
approved these changes
Aug 13, 2021
ephraimbuddy
force-pushed
the
fix-triggerer-query
branch
from
2a4373f
to
c2d0e7b
Compare
kaxil
approved these changes
Aug 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the triggerrer query where limit is not supported in some DB versions and also fixed the issue where total_hours was used on a timedelta.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.