-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert issue templates into forms #17855
Conversation
You can try it here: https://github.com/potiuk/airflow/issues/new/choose - feel free to create new issues there to see how they look like! |
Love it! Will review for typos, but 💯 for this change! |
Oh yeah. I really hope it's gone bring the quality of the issues we got up and their number down. But you never know. The users are creative :D |
See my reasoning above @leahecole . I am not super-strong about it, but this is the best balance I found between "easy way to add meta features/tasks" by maintainers and "difficult to enter legitmate issue without providing all the necessary details" by contributors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly grammar related nits. Really glad you're doing this - thank you so much @potiuk!
Good point. I will add it! |
Sounds like a good job for a bot 😎 |
Oh yeah! |
I think I addressed all comments. Please take a look @eladkal @leahecole @BasPH @jedcunningham @uranusjr and anyone else interested. The change depends on #17858 - as during testing I found out some issues with pre-commits validating provider.yaml (and #17858 corrects errors resulting from it) To make it easier to review, I squashed all the speling/etc fixes into a single commit, and added all new things in the fixup commit that follows. Those are:
You can try it out here: https://github.com/potiuk/airflow/issues/new/choose |
And @eladkal -> labels are set properly to doc/core/provider kind of issues. Should help with triaging :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed one 🤦♂️
b995ffd
to
7438b66
Compare
The latest fixup contains last round of grammar/content reviews. I think we are close to a "mergable" status on that one. I thought hat we might want to be more "welcoming" and "airflow-y" in the issues and here is what I came up with: Any more comments? Again - you can play with the latest version here: https://github.com/potiuk/airflow/issues/new/choose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
I am going to merge it as is, and we can always make corrections later :D |
[After fixing the static check that is] |
Following the discussion at https://lists.apache.org/x/thread.html/r36d084d83cf7a66698c84185558e1bbe971c59533d4ac5d4994b0aca@%3Cdev.airflow.apache.org%3E The issue templates are now Forms.
Rebuilding to check latest constraint works after celery 5 merge. |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Following the discussion at
https://lists.apache.org/x/thread.html/r36d084d83cf7a66698c84185558e1bbe971c59533d4ac5d4994b0aca@%3Cdev.airflow.apache.org%3E
The issue templates are now Forms.
Depends on #17858