Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds capability of Warnings for incompatible community providers #18020

Merged
merged 1 commit into from
Sep 4, 2021

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Sep 3, 2021

When we release providers, we do not know if some future version
of Airflow will be incompatible with them, so we cannot add hard
limits there. We have constraints that contain the "latest"
providers at the moment of release but if someone has an old
versions of providers installed and just upgrades Airflow, the
incompatible versions of providers might be still installed.

From now on Airflow will print warnings in case such incompatible
provider is detected.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@potiuk
Copy link
Member Author

potiuk commented Sep 3, 2021

This one will fail until we merge #18018 is merged (it bumps celery to 2.1.0)

airflow/providers_manager.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 3, 2021
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@potiuk potiuk force-pushed the add-warnings-for-incompatible-providers branch from c6c6849 to d599a6c Compare September 3, 2021 21:10
When we release providers, we do not know if some future version
of Airflow will be incompatible with them, so we cannot add hard
limits there. We have constraints that contain the "latest"
providers at the moment of release but if someone has an old
versions of providers installed and just upgrades Airflow, the
incompatible versions of providers might be still installed.

From now on Airflow will print warnings in case such incompatible
provider is detected.
@potiuk potiuk force-pushed the add-warnings-for-incompatible-providers branch from d599a6c to 0937cd3 Compare September 4, 2021 07:58
@potiuk potiuk merged commit b486a0e into apache:main Sep 4, 2021
@potiuk potiuk deleted the add-warnings-for-incompatible-providers branch September 4, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants