Advises the kernel to not cache log files generated by Airflow #18054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
commented
Sep 7, 2021
potiuk
force-pushed
the
disable-caching-for-log-generation
branch
2 times, most recently
from
fd6070f
to
f18e7a0
Compare
Extends the standard python logging.FileHandler with advise to the Kernel to not cache the file in PageCache when it is written. While there is nothing wrong with such cache (it will be cleaned when memory is needed), it causes ever-growing memory usage when scheduler is running as it keeps on writing new log files and the files are not rotated later on. This might lead to confusion for our users, who are monitoring memory usage of Scheduler - without realising that it is harmless and expected in this case. Adding the advice to Kernel might help with not generating the cache memory growth in the first place. Closes: apache#14924
potiuk
force-pushed
the
disable-caching-for-log-generation
branch
from
f18e7a0
to
79dc130
Compare
ashb
reviewed
Sep 8, 2021
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
|
Seems that the fix works as expected - the hint to kernel does the job! |
|
The failure is intermittent @ashb - and even if it was not a "real" memory leak, I think it might help a lot with "false-positive" reports of memory leaking :) |
ashb
approved these changes
Sep 9, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
pushed a commit
that referenced
this pull request
Sep 15, 2021
* Advises the kernel to not cache log files generated by Airflow Extends the standard python logging.FileHandler with advise to the Kernel to not cache the file in PageCache when it is written. While there is nothing wrong with such cache (it will be cleaned when memory is needed), it causes ever-growing memory usage when scheduler is running as it keeps on writing new log files and the files are not rotated later on. This might lead to confusion for our users, who are monitoring memory usage of Scheduler - without realising that it is harmless and expected in this case. Adding the advice to Kernel might help with not generating the cache memory growth in the first place. Closes: #14924 (cherry picked from commit 43f595f)
Closed
2 tasks
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 24, 2022
The RotatingFileHandler is used when you enable it via `CONFIG_PROCESSOR_MANAGER_LOGGER=True` and it exhibits similar behaviour as the FileHandler had when it comes to caching the file on the Kernel level. While it is harmless (the cache will be freed when needed), it is also misleading for those who are trying to understand memory usage by Airlfow. The fix is to add a custom non-caching RotatingFileHandler similarly as in apache#18054. Note that it will require to manually modify local settings if the settings were created before this change. Fixes: apache#27065
potiuk
added a commit
that referenced
this pull request
Oct 25, 2022
The RotatingFileHandler is used when you enable it via `CONFIG_PROCESSOR_MANAGER_LOGGER=True` and it exhibits similar behaviour as the FileHandler had when it comes to caching the file on the Kernel level. While it is harmless (the cache will be freed when needed), it is also misleading for those who are trying to understand memory usage by Airlfow. The fix is to add a custom non-caching RotatingFileHandler similarly as in #18054. Note that it will require to manually modify local settings if the settings were created before this change. Fixes: #27065
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 9, 2022
The RotatingFileHandler is used when you enable it via `CONFIG_PROCESSOR_MANAGER_LOGGER=True` and it exhibits similar behaviour as the FileHandler had when it comes to caching the file on the Kernel level. While it is harmless (the cache will be freed when needed), it is also misleading for those who are trying to understand memory usage by Airlfow. The fix is to add a custom non-caching RotatingFileHandler similarly as in #18054. Note that it will require to manually modify local settings if the settings were created before this change. Fixes: #27065 (cherry picked from commit 126b7b8)
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 9, 2022
The RotatingFileHandler is used when you enable it via `CONFIG_PROCESSOR_MANAGER_LOGGER=True` and it exhibits similar behaviour as the FileHandler had when it comes to caching the file on the Kernel level. While it is harmless (the cache will be freed when needed), it is also misleading for those who are trying to understand memory usage by Airlfow. The fix is to add a custom non-caching RotatingFileHandler similarly as in #18054. Note that it will require to manually modify local settings if the settings were created before this change. Fixes: #27065 (cherry picked from commit 126b7b8)
2 tasks
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends the standard python logging.FileHandler with advise to the
Kernel to not cache the file in PageCache when it is written. While
there is nothing wrong with such cache (it will be cleaned when memory
is needed), it causes ever-growing memory usage when scheduler is
running as it keeps on writing new log files and the files are not
rotated later on. This might lead to confusion for our users, who are
monitoring memory usage of Scheduler - without realising that it is
harmless and expected in this case.
Adding the advice to Kernel might help with not generating the cache
memory growth in the first place.
Closes: #14924
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.