Adding Variable.update method and improving detection of variable key collisions #18159
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: Discussion in #17889
A few changes in this PR:
Variable.set()
method to take adescription
argument.Variable.setdefault()
method to take adescription
argument.Variable.update()
method which will throw aKeyError
if the Variable doesn't exist, and anAttributeError
if it doesn't exist in the Database (since a non-metastore Variable can't be modified)If a user has a duplicated key in the metastore and an extra secrets backend, then updates to the Variable will update the value in the metastore, but reads will read the value in the additional backend.
This is still the case, but I've improved the logging when this happens and updated the documentation to warn users about this behaviour.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.