Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about params on trigger DAG page #18166

Merged
merged 3 commits into from
Sep 12, 2021
Merged

Conversation

msumit
Copy link
Contributor

@msumit msumit commented Sep 11, 2021


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 11, 2021
@msumit msumit requested review from kaxil and potiuk September 11, 2021 13:17
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add PR description to explain a bit more on what we are doing and why

airflow/www/templates/airflow/trigger.html Outdated Show resolved Hide resolved
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 11, 2021
@msumit
Copy link
Contributor Author

msumit commented Sep 12, 2021

We should also add PR description to explain a bit more on what we are doing and why

In general true, but in this PR the title is self-sufficient :)

@msumit msumit merged commit d7aed84 into apache:main Sep 12, 2021
@msumit msumit deleted the params_info branch September 12, 2021 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants