Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap dag import error dropdown icons #18207

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

bbovenzi
Copy link
Contributor

Open/Close icons were backwards. This swaps them to be consistent with the expand/contract the whole dag error banner

Closes #18100

Now:
Screen Shot 2021-09-13 at 5 52 18 PM
Screen Shot 2021-09-13 at 5 52 22 PM


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

- Open/Close icons were backwards. This swaps them to be consistent with the expand/contract the whole dag error banner
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 13, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 13, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@bbovenzi bbovenzi merged commit d3d847a into apache:main Sep 13, 2021
@bbovenzi bbovenzi deleted the swap-error-chevron branch September 13, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAG Import Errors Broken DAG Dropdown Arrow Icon Switched
2 participants