Add some basic metrics to the Triggerer #18214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewgodwin
force-pushed
the
triggerer_metrics
branch
from
a012cd6
to
6c2c2b4
Compare
kaxil
approved these changes
Sep 13, 2021
kaxil
reviewed
Sep 13, 2021
There was a problem hiding this comment.
Can you add them to https://github.com/apache/airflow/blob/main/docs/apache-airflow/logging-monitoring/metrics.rst please
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
force-pushed
the
triggerer_metrics
branch
from
6c2c2b4
to
0e965e6
Compare
|
@andrewgodwin Can you add docs to https://github.com/apache/airflow/blob/main/docs/apache-airflow/logging-monitoring/metrics.rst, please? |
andrewgodwin
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 14, 2021
Follow-on from apache#18214
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Mar 10, 2022
Follow-on from apache/airflow#18214 GitOrigin-RevId: 29d700dd3de7ede6b5c426f397418deb3cc7a916
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jun 4, 2022
Follow-on from apache/airflow#18214 GitOrigin-RevId: 29d700dd3de7ede6b5c426f397418deb3cc7a916
kosteev
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jul 10, 2022
Follow-on from apache/airflow#18214 GitOrigin-RevId: 29d700dd3de7ede6b5c426f397418deb3cc7a916
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Aug 27, 2022
Follow-on from apache/airflow#18214 GitOrigin-RevId: 29d700dd3de7ede6b5c426f397418deb3cc7a916
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 4, 2022
Follow-on from apache/airflow#18214 GitOrigin-RevId: 29d700dd3de7ede6b5c426f397418deb3cc7a916
aglipska
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Oct 7, 2022
Follow-on from apache/airflow#18214 GitOrigin-RevId: 29d700dd3de7ede6b5c426f397418deb3cc7a916
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Dec 7, 2022
Follow-on from apache/airflow#18214 GitOrigin-RevId: 29d700dd3de7ede6b5c426f397418deb3cc7a916
leahecole
pushed a commit
to GoogleCloudPlatform/composer-airflow
that referenced
this pull request
Jan 27, 2023
Follow-on from apache/airflow#18214 GitOrigin-RevId: 29d700dd3de7ede6b5c426f397418deb3cc7a916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some basic metrics to the Triggerer:
triggers.running: A gauge of how many are currently runningtriggers.succeededandtriggers.failed: Counters of how many triggers have fired successfully/failed, respectively.