Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return explicit error on user-add for duplicated email #18224

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Return explicit error on user-add for duplicated email #18224

merged 4 commits into from
Sep 14, 2021

Conversation

uranusjr
Copy link
Member

Fix #18204.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Sep 14, 2021
@uranusjr uranusjr changed the title Emit explicit exception if user fails to add due to db errors Emit explicit exception if user fails to add due to duplicated email Sep 14, 2021
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Sep 14, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr @mik-laj
Use example.org as default user email in tests
1d8a2a9 
Co-authored-by: Kamil Breguła <mik-laj@users.noreply.github.com>
@uranusjr uranusjr changed the title Emit explicit exception if user fails to add due to duplicated email Return explicit error on user-add for duplicated email Sep 14, 2021
@uranusjr uranusjr merged commit 7a19124 into apache:main Sep 14, 2021
@uranusjr uranusjr deleted the api-user-create-errors branch September 14, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mik-laj mik-laj mik-laj left review comments

@potiuk potiuk potiuk approved these changes

@msumit msumit msumit approved these changes

@kaxil kaxil kaxil approved these changes

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees
No one assigned
Labels
area:API Airflow's REST/HTTP API full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

POST /api/v1/users fails with exception
5 participants
@uranusjr @potiuk @msumit @kaxil @mik-laj