Fix DB session handling in XCom.set. #18240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the function has the `@provide_session` decorator it should not be committing the session (the decorator handles that if it's not passed a session) and nor should it be calling expunge_all -- that detaches all objects from the session which is just not needed (or right) behaviour form setting an XCom value. By using the `session` fixture we get the transaction automatically rolled back, so we don't need any setup/teardown methods
kaxil
force-pushed
the
fix-xcom-sesison-handling
branch
from
2c7bc5b
to
aab7f0a
Compare
|
Are even the |
uranusjr
approved these changes
Sep 15, 2021
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Possibly not striclty needed, but its hard to reason about where this might be used, so a flush is safer |
kaxil
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the function has the
@provide_sessiondecorator it should not becommitting the session (the decorator handles that if it's not passed a
session) and nor should it be calling expunge_all -- that detaches all
objects from the session which is just not needed (or right) behaviour
form setting an XCom value.
By using the
sessionfixture we get the transaction automaticallyrolled back, so we don't need any setup/teardown methods.
(This is a prep PR for fixing the deserialize behavoiur of XCom.get_one)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.