Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure task view can be rendered without a ti #18244

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

uranusjr
Copy link
Member

Fix #18242, fix #18188.

These views should now work, but I want to add a couple of tests for these views as well.

@uranusjr uranusjr added the AIP-39 Timetables label Sep 14, 2021
@uranusjr uranusjr added this to the Airflow 2.2 milestone Sep 14, 2021
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 14, 2021
@uranusjr
Copy link
Member Author

Forgot to mention:

  • The “task” view should now show “No Task Instance Available” instead of the “Task Instance Attributes” table (most of the values in the table are meaningless anyway since they are not “real” without an actual DAG run).
  • The “rendered” view should work properly as in Airflow 2.1.x.

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested locally. It solves the issue

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 14, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@uranusjr uranusjr marked this pull request as ready for review September 15, 2021 04:01
airflow/www/templates/airflow/task.html Outdated Show resolved Hide resolved
@uranusjr uranusjr merged commit c313feb into apache:main Sep 16, 2021
@uranusjr uranusjr deleted the aip-39-task-view-without-ti branch September 16, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-39 Timetables area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
3 participants