Ability to access http k8s via multiple hostnames #18257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredthomsen
requested review from
ashb,
dimberman,
jedcunningham and
kaxil
as code owners
mik-laj
reviewed
Sep 15, 2021
jedcunningham
requested changes
Sep 15, 2021
fredthomsen
force-pushed
the
multipleHostnameIngress
branch
3 times, most recently
from
b1c3011
to
c3696bf
Compare
I've added some tests. Looking at the other tests, I think this is what we're looking for but wasn't too sure of myself. |
fredthomsen
force-pushed
the
multipleHostnameIngress
branch
3 times, most recently
from
ec5440d
to
dfb28d4
Compare
Add support for accessing the airflow ui and the flower ui (if applicable) from multiple hostnames when install via helm chart onto a kubernetes cluster. closes: apache#18216.
fredthomsen
force-pushed
the
multipleHostnameIngress
branch
from
dfb28d4
to
a1ff12a
Compare
jedcunningham
approved these changes
Sep 17, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template the airflow ui and flower ingress in the helm chart to enable them
to be accessed via multiple hostnames. Also quote hostnames so that
wildcard hostnames can be used.
The old field specifying a single hostname has been marked as deprecated, but can still be used maintaining backwards compatibility. This does not allow different paths to be associated with different hosts. I was concerned about increasing the complexity too much here while trying to keep backwards compatability.
closes: #18216.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.