Make XCom.get_one return full, not abbreviated values
#18274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you used this class method directly (such as in a custom operator link) then the value would _always_ be subject to the `orm_deserialize_value` which would likely give the wrong result on custom XCom backends. This wasn't a problem for anyone using `ti.xcom_pull` as it handled this directly.
uranusjr
reviewed
Sep 15, 2021
Comment on lines
+192
to
+193
| This function returns an SQLAlchemy query of full XCom objects. If you just want one stored value then | ||
| use :meth:`get_one`. |
There was a problem hiding this comment.
Perhaps also mention with_entities() for people who want a list of values? (If that’s a meaningful use case.)
There was a problem hiding this comment.
I think a more whole-sale reworking of this to make the serde handled automatically is in order, so I'm going to leave this as is for now.
uranusjr
approved these changes
Sep 15, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
kaxil
approved these changes
Sep 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you used this class method directly (such as in a custom operator link) then the value would always be subject to the
orm_deserialize_valuewhich would likely give the wrong result on custom XCom backends.This wasn't a problem for anyone using
ti.xcom_pullas it handled this directly.