Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix task group tooltip #18406

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

bbovenzi
Copy link
Contributor

The task group tooltip wasn't just not loading the right info, but it wasn't rendering at all. This PR fixes that.

Also:

  • add deferred as a group node status
  • show all possible status summaries in the group tooltip but only show them if the count is >0

Closes #16887

Screen Shot 2021-09-21 at 3 38 52 PM


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

The task group tooltip wasn't just not loading the right info, but it wasn't rendering at all. This PR fixes that.

Also:
- add `deferred` as a group node status
- show all possible status summaries in the group tooltip but only show them if the count is >0
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Sep 21, 2021
@bbovenzi bbovenzi closed this Sep 21, 2021
@bbovenzi bbovenzi reopened this Sep 21, 2021
Copy link
Contributor

@ryanahamilton ryanahamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Sep 23, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@bbovenzi bbovenzi merged commit deb01dd into apache:main Sep 23, 2021
@bbovenzi bbovenzi deleted the fix-task-group-tooltip branch September 23, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show duration of a task group
2 participants