Add muldelete action to TaskInstanceModelView and tests. Change permissions for TaskInstanceModelView.action_clear to "delete"

[alex-astronomer]

Closes #18333. Adds a Delete option in TaskInstanceModelView and deletes multiple TaskInstances based on which options are checked in the model view. Added unit tests for this as well. Tests that the right tasks get deleted and also tests that deletes get cascaded to TaskReschedules in the meta DB.

Also, changed permissions for DagRunModelView's action_clear to be edit instead of delete.

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

[alex-astronomer]

Need to add an assert here... Adjusting now.

[bbovenzi]

nice work!

[github-actions]

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

[Jorricks]

There is a security issue here.
People will be able to delete TaskInstances that the person should not have access too.
You would just need to change the post values with a primary_key of another TaskInstance you don't have access too.
Therefore, please add the @action_has_dag_edit_access decorator.

[Jorricks]

People will be able to delete TaskInstances that the person should not have access too.

I created a PR to add a test to avoid the security issue in the future: #18467.
Please don't take my comment the wrong way, I appreciate the work you are doing and thing it is a clean implementation ✌️.
I should have written this test earlier and it's my mistake this wasn't made clear by the tests.

[alex-astronomer]

People will be able to delete TaskInstances that the person should not have access too.

I created a PR to add a test to avoid the security issue in the future: #18467.
Please don't take my comment the wrong way, I appreciate the work you are doing and thing it is a clean implementation ✌️.
I should have written this test earlier and it's my mistake this wasn't made clear by the tests.

No offense taken, I'm happy that you commented because now I can learn something from this. I was wondering how I missed something like that since I just referred to the DagRun equivalent of the muldelete function but it looks like that decorator was added 2 days ago and I just wasn't up to date on my main branch. Good catch. I'm going to add that now.

[Jorricks]

Nice, PR LGTM :)

[alex-astronomer]

Any update on this one, merge team?

[alex-astronomer]

@jedcunningham Changes addressed!

[Jorricks]

@jedcunningham Changes addressed!

Nice work 👍