Don't use flash for "same-page" UI messages. #18462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
bbovenzi
approved these changes
Sep 23, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
reviewed
Sep 23, 2021
uranusjr
approved these changes
Sep 23, 2021
ashb
force-pushed
the
no-flash-for-inpage-warnings
branch
from
220c7a7
to
59da726
Compare
jedcunningham
approved these changes
Sep 23, 2021
ashb
force-pushed
the
no-flash-for-inpage-warnings
branch
from
59da726
to
918aeeb
Compare
The flash is designed for setting a message on one page and then showing it after a redirect, so in the case of these UI warnings they were being shown twice due to an early redirect. I could have chosen to fix this by moving the checks to after the `reset_tags` redirect, but it _also_ felt wrong to me to have HTML in the view, so I have chosen to move it in to the template where it belongs. To (marginally) reduce boilerplate I have created `message()` "macro" (Jinja macro, a.k.a. function; not to be confused with what Airflow templates call a macro, but is in fact just a template global) that handles the formatting for messages.
ashb
force-pushed
the
no-flash-for-inpage-warnings
branch
from
918aeeb
to
8eff794
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flash is designed for setting a message on one page and then showing
it after a redirect, so in the case of these UI warnings they were being
shown twice due to an early redirect.
I could have chosen to fix this by moving the checks to after the
reset_tagsredirect, but it also felt wrong to me to have HTML inthe view, so I have chosen to move it in to the template where it
belongs.
To (marginally) reduce boilerplate I have created
message()"macro"(Jinja macro, a.k.a. function; not to be confused with what Airflow
templates call a macro, but is in fact just a template global) that
handles the formatting for messages.
Closes #17727