Fix example timetable for AIP-39 howto #18475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
commented
Sep 23, 2021
| @@ -54,7 +54,7 @@ def next_dagrun_info( | |||
| ) -> Optional[DagRunInfo]: | |||
| if last_automated_data_interval is not None: # There was a previous run on the regular schedule. | |||
| last_start = last_automated_data_interval.start | |||
| last_start_weekday = 7 - last_start.weekday() | |||
| last_start_weekday = last_start.weekday() | |||
uranusjr
force-pushed
the
aip-39-example-timetable-schedule-fix
branch
from
fb19320
to
5eedd50
Compare
uranusjr
changed the title
josh-fell
reviewed
Sep 23, 2021
This makes the DAG "work" out of the box, which makes more sense.
uranusjr
force-pushed
the
aip-39-example-timetable-schedule-fix
branch
from
5eedd50
to
00ffe5e
Compare
kaxil
approved these changes
Sep 23, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wonderful QA team caught me doing stupid things. This fixes that. Plus:
dag_idandstart_dateto the example DAG. This was also suggested by the QA team.