-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make AirflowDateTimePickerWidget
a required field
#18602
Conversation
Thanks to @bbovenzi we now have a default value in the UI for date fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the path to trigger this?
Your fix looks suspect to me, and instead of using "now" as the value I think we want to just return the query un-altered in that case.
An even better fix might be to change the field validation so that null is not allowed/is never passed to the filter!
The trigger is to go to browse >> task instances and select |
Yeah, that is improper validation then -- we should fix that instead |
Disabling the input when the values are null disables the DateTime picker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be preferable to just disable the submit button on the search form but it is built by FAB. This is a decent solution that requires less changes I believe.
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
Related issue: #15976 |
90cb423
to
f930004
Compare
The UI breaks when a search field sends a null datetime. This fixes it
f930004
to
abf19ca
Compare
AirflowDateTimePickerWidget
a required field
The UI breaks when a search field sends a null datetime. This fixes it.
Closes #15976