Properly set start_date for cleared tasks #18708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ashb,
kaxil,
mik-laj and
XD-DENG
as code owners
kaxil
approved these changes
Oct 4, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
ephraimbuddy
force-pushed
the
clear-tasks-in-queued
branch
from
f801d71
to
23aca9d
Compare
This PR ensures that when we clear task instances, the start_date for the dagrun is set correctly. If the dag_run_state is queued we should set the start_date to None otherwise start_date should be set to timezone.utcnow Also, in the clear task instances API endpoint, the state of the dagrun is being set to RUNNING on clear. This PR addresses it too.
ephraimbuddy
force-pushed
the
clear-tasks-in-queued
branch
from
23aca9d
to
b77b358
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that when we clear task instances, the start_date for the dagrun is set correctly.
If the dag_run_state is queued we should set the start_date to None otherwise start_date should be
set to timezone.utcnow
Also, in the clear task instances API endpoint, the state of the dagrun is being set to RUNNING on
clear. This PR addresses it too.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.