Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the Helm hooks in the helm chart #18776

Merged

Conversation

Mrngilles
Copy link
Contributor

Following #17447, I added a way to disable the Helm hooks so that the jobs are properly created in ArgoCD.

This does not change the default behavior of the helm chart, but makes it more flexible


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Oct 6, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 6, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now (until we get better way to handle upgrades

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Oct 6, 2021
@mik-laj
Copy link
Member

mik-laj commented Oct 6, 2021

Can you add docs about this option to docs/helm-chart?

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add tests?

@Mrngilles
Copy link
Contributor Author

Sure, I'll get that done. Thanks for the review

@Mrngilles
Copy link
Contributor Author

Added tests and documentation. Let me know if you want me to add more of those

@Mrngilles Mrngilles force-pushed the helm/optional-disable-helm-hooks branch from c5944f7 to a25e0f3 Compare November 5, 2021 09:15
@jedcunningham jedcunningham added this to the Airflow Helm Chart 1.3.0 milestone Nov 5, 2021
@jedcunningham jedcunningham merged commit 35f3bf8 into apache:main Nov 5, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Nov 5, 2021

Awesome work, congrats on your first merged pull request!

@jedcunningham
Copy link
Member

Thanks for the contribution @Mrngilles! Congrats on your first commit 🎉

@potiuk
Copy link
Member

potiuk commented Nov 5, 2021

Cool!

@kylegalea
Copy link

this change should have been added to 1.3.0 but is not there

@jedcunningham
Copy link
Member

Thanks @kylegalea, I see that it isn't in there, but it should have been. Let me investigate further.

@jedcunningham
Copy link
Member

@kylegalea, thanks for bringing this up! Sorry I accidentally messed up getting this into 1.3.0. It'll definitely make it into 1.4.0.

kaxil added a commit to astronomer/airflow that referenced this pull request Dec 3, 2021
apache#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job
kaxil added a commit that referenced this pull request Dec 3, 2021
#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 10, 2022
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job

GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job

GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job

GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job

GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job

GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023
apache/airflow#18776 introduced a bug where it changed the Helm Hook weight for Create User job from 2 to 1. It needs to be 2 as we want to run migrations first even before create-user-job

GitOrigin-RevId: 7d97547257ae436ea35ee35cf1a598ebd080050f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants