-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect type comment in Swagger2Specification._set_defaults classmethod #19065
Remove incorrect type comment in Swagger2Specification._set_defaults classmethod #19065
Conversation
@uranusjr Please, can you help me with this PR? I don't understand why one of the checks was failed (( |
Don't worry about that, it's unrelated and will be fixed separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what the policy of updating things in _vendor
is though, waiting for someone who does to do the merge.
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
We usually don't chenge vendored code. We could potentially exclude the connexion package from |
CC: @jedcunningham - if there is still time - might be good to cherry-pick that one to 2.2.1 - it's 0-risk change that solves real issue of the users. |
@jedcunningham - I cherry-picked it now to v2-2-test |
related: #19006