Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect type comment in Swagger2Specification._set_defaults classmethod #19065

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

brain-buster
Copy link
Contributor

related: #19006

@brain-buster
Copy link
Contributor Author

@uranusjr Please, can you help me with this PR? I don't understand why one of the checks was failed ((

@uranusjr
Copy link
Member

Don't worry about that, it's unrelated and will be fixed separately.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the policy of updating things in _vendor is though, waiting for someone who does to do the merge.

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 19, 2021
@zachliu zachliu mentioned this pull request Oct 23, 2021
@potiuk
Copy link
Member

potiuk commented Oct 23, 2021

We usually don't chenge vendored code. We could potentially exclude the connexion package from mypy checks but (from what I understand) in this case it is not "airflow's" mypy that fails but the problem is that if the user want to check their own DAG that imports airflow. It would be a bit too much to require from our users to exclude the package with their mypy checks, and since the fix is simple (and without any runtime code change), and the same fix is already done in upstream, I see no reason why we should not merge it.

@potiuk potiuk merged commit 1fb4729 into apache:main Oct 23, 2021
@potiuk potiuk added this to the Airflow 2.2.1 milestone Oct 23, 2021
@potiuk
Copy link
Member

potiuk commented Oct 23, 2021

CC: @jedcunningham - if there is still time - might be good to cherry-pick that one to 2.2.1 - it's 0-risk change that solves real issue of the users.

potiuk pushed a commit that referenced this pull request Oct 23, 2021
@potiuk
Copy link
Member

potiuk commented Oct 23, 2021

@jedcunningham - I cherry-picked it now to v2-2-test

jedcunningham pushed a commit that referenced this pull request Oct 24, 2021
sharon2719 pushed a commit to sharon2719/airflow that referenced this pull request Oct 27, 2021
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants