Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ds, ts, etc. back to use logical date #19088

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

uranusjr
Copy link
Member

One part of the step 1 as outlined in #19058 (comment)

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I'm surprised this didn't need any test changes though?

@uranusjr
Copy link
Member Author

Because all existing tests have matching execution_date and data_interval_start. I'll add a test that replicates the failure in #19058 so this won't regress acidentally.

@uranusjr uranusjr marked this pull request as ready for review October 20, 2021 02:39
@uranusjr
Copy link
Member Author

Test added

@uranusjr uranusjr added this to the Airflow 2.2.1 milestone Oct 20, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Oct 20, 2021
@jedcunningham jedcunningham merged commit 25a50bb into apache:main Oct 20, 2021
@uranusjr uranusjr deleted the logical-date-in-templates branch October 20, 2021 18:18
jedcunningham pushed a commit that referenced this pull request Oct 20, 2021
jedcunningham pushed a commit to astronomer/airflow that referenced this pull request Oct 26, 2021
sharon2719 pushed a commit to sharon2719/airflow that referenced this pull request Oct 27, 2021
jedcunningham pushed a commit to astronomer/airflow that referenced this pull request Oct 27, 2021
@jedcunningham jedcunningham added the type:bug-fix Changelog: Bug Fixes label Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
full tests needed We need to run full set of tests for this PR to merge kind:documentation type:bug-fix Changelog: Bug Fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants