Ensure task state doesn't change when marked as failed/success/skipped #19095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add tests later... |
uranusjr
approved these changes
Oct 20, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
Currently, when a dagrun is marked as success in the UI, the expected sigterm is sent but the task continues running, changing the dagrun to running before eventually failing. Same as well when marked as failed. Also, queued tasks continue running even when the dagrun was failed The same thing happens when a dagrun times out. The tasks that are marked skipped, starts again, and then fails. This PR fixes these issues
ephraimbuddy
force-pushed
the
properly-set-state
branch
from
48dd90a
to
c3d677a
Compare
jedcunningham
pushed a commit
that referenced
this pull request
Oct 20, 2021
#19095) Currently, when a dagrun is marked as success in the UI, the expected sigterm is sent but the task continues running, changing the dagrun to running before eventually failing. Same as well when marked as failed. Also, queued tasks continue running even when the dagrun was failed The same thing happens when a dagrun times out. The tasks that are marked skipped, starts again, and then fails. This PR fixes these issues (cherry picked from commit 8d703ae)
ephraimbuddy
added a commit
to astronomer/airflow
that referenced
this pull request
Oct 26, 2021
When changing the state of ti to None if the dagrun is in a finished state, to avoid queueing the task, scheduler raises unexpected commit. The reason is that I didn't pass a session to ti.set_state in apache#19095 This happens when you mark a dagrun successful/failed and there are some taskinstances that are not yet queued in the dagrun.
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 26, 2021
apache#19095) Currently, when a dagrun is marked as success in the UI, the expected sigterm is sent but the task continues running, changing the dagrun to running before eventually failing. Same as well when marked as failed. Also, queued tasks continue running even when the dagrun was failed The same thing happens when a dagrun times out. The tasks that are marked skipped, starts again, and then fails. This PR fixes these issues (cherry picked from commit 8d703ae)
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
apache#19095) Currently, when a dagrun is marked as success in the UI, the expected sigterm is sent but the task continues running, changing the dagrun to running before eventually failing. Same as well when marked as failed. Also, queued tasks continue running even when the dagrun was failed The same thing happens when a dagrun times out. The tasks that are marked skipped, starts again, and then fails. This PR fixes these issues
37 tasks
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 27, 2021
apache#19095) Currently, when a dagrun is marked as success in the UI, the expected sigterm is sent but the task continues running, changing the dagrun to running before eventually failing. Same as well when marked as failed. Also, queued tasks continue running even when the dagrun was failed The same thing happens when a dagrun times out. The tasks that are marked skipped, starts again, and then fails. This PR fixes these issues (cherry picked from commit 8d703ae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #16078
Currently, when a dagrun is marked as success in the UI, the expected
sigterm is sent but the task continues running, changing the dagrun to running
before eventually failing. Same as well when marked as failed.
Also, queued tasks continue running even when the dagrun was failed
The same thing happens when a dagrun times out. The tasks that are marked
skipped, starts again, and then fails.
This PR fixes these issues
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.