Hide tooltip when next run is none #19112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for `is not none` instead of `is defined` when showing the next run tooltip
boring-cyborg
bot
added
area:UI
bbovenzi
changed the title
uranusjr
approved these changes
Oct 20, 2021
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
ryanahamilton
approved these changes
Oct 20, 2021
|
Tests are failing |
jedcunningham
pushed a commit
that referenced
this pull request
Oct 22, 2021
* Hide Next Run when it is None Check for `is not none` instead of `is defined` when showing the next run tooltip * check next_dagrun is defined and not none (cherry picked from commit e6fcf77)
jedcunningham
pushed a commit
that referenced
this pull request
Oct 24, 2021
* Hide Next Run when it is None Check for `is not none` instead of `is defined` when showing the next run tooltip * check next_dagrun is defined and not none (cherry picked from commit e6fcf77)
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
* Hide Next Run when it is None Check for `is not none` instead of `is defined` when showing the next run tooltip * check next_dagrun is defined and not none
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for
is not noneinstead ofis definedwhen showing the next run tooltip. I think it's still useful to show the badge though.Before:
After:
Same view, just no tooltip will appear on hover.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.