Crerate TI context with data interval compat layer #19148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old DAG runs created prior to 2.2 do not have a concrete data interval, but we still want to be able to add things to them with a consistent interface, so the context should use the compat layer instead of relying on the database entry.
|
Tentatively adding this to 2.2.1 since this is a regression in 2.2.0, and the fix should not introduce any risk. |
ephraimbuddy
approved these changes
Oct 22, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
jedcunningham
pushed a commit
that referenced
this pull request
Oct 22, 2021
(cherry picked from commit 1159133)
jedcunningham
pushed a commit
that referenced
this pull request
Oct 24, 2021
(cherry picked from commit 1159133)
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 26, 2021
(cherry picked from commit 1159133)
sharon2719
pushed a commit
to sharon2719/airflow
that referenced
this pull request
Oct 27, 2021
37 tasks
jedcunningham
pushed a commit
to astronomer/airflow
that referenced
this pull request
Oct 27, 2021
(cherry picked from commit 1159133)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #19143.
Old DAG runs created prior to 2.2 do not have a concrete data interval, but we still want to be able to add things to them with a consistent interface, so the context should use the compat layer instead of relying
on the database entry.